Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use read-write locks instead of mutexes in authentication handling #3210

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Use read-write locks instead of mutexes in authentication handling #3210

merged 2 commits into from
Apr 24, 2024

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Apr 23, 2024

  • Use RwLock for KeyringProvider cache
  • Use RwLock for CredentialsCache

@zanieb zanieb added the performance Potential performance improvement label Apr 23, 2024
zanieb
zanieb commented Apr 23, 2024
View reviewed changes
crates/uv-auth/src/keyring.rs Outdated Show resolved Hide resolved
@zanieb
Copy link
Member Author

zanieb commented Apr 23, 2024

cc @naosense

@zanieb zanieb requested a review from BurntSushi April 23, 2024 14:44
BurntSushi
BurntSushi approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@BurntSushi BurntSushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

crates/uv-auth/src/keyring.rs Outdated Show resolved Hide resolved
@zanieb zanieb merged commit a07adf7 into main Apr 24, 2024
40 checks passed
@zanieb zanieb deleted the zb/locks branch April 24, 2024 15:17
@BrewTestBot BrewTestBot mentioned this pull request Apr 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BurntSushi BurntSushi BurntSushi approved these changes

@naosense naosense naosense left review comments

Assignees
No one assigned
Labels
performance Potential performance improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zanieb @BurntSushi @naosense