Fix fetch of credentials when cache is seeded with username #3206
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the failure to lookup credentials in #3205
The issue is that we seed the cache with the index URL which includes a username but no password. We did not ensure that a password was present in the cached credentials before attempting a request with them. Now, the cache will not return credentials when a username is provided and the cached credentials have no password — the cached credentials are useless in that case.
Tested with a Google Artifact Registry and keyring