Add UV_CONSTRAINT environment variable to provide value for --constraint
#3162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failure looks like network error |
|
I think space-delimiting is ok, since it's at least compatible with pip and the other arguments we added. |
Czaki
added a commit
to Czaki/uv
that referenced
this pull request
Apr 22, 2024
AlexWaygood
pushed a commit
that referenced
this pull request
Apr 22, 2024
## Summary When creating #3162 I used a single quote `'` instead of grave accent `` ` ``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is adding
UV_CONSTRAINTenvironment variable as analogous toPIP_CONSTRAINTto allow providing constraint file via environment variable. Implementing this will simplify adoption of uv in testing procedure in projects that I'm involved (testing using tox).This was my motivation for opening #1841 that is closed in favor of #1789 which was closed without implementing this feature.
In this implementation, I have used space as a separator as analogous to
pip. This introduces an obvious problem if the path contains space. Another option could be to use standard separator (:- UNIX like,;- Windows). Which one did you prefer?Test Plan
It is my first contribution and first rust coding experience. It will be nice if one could point how I should implement testing this.