Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix venvlauncher.exe reference in venv creation #3160

Merged
merged 2 commits into from
Apr 20, 2024
Merged

Conversation

charliermarsh
Copy link
Member

@charliermarsh charliermarsh commented Apr 20, 2024

I can't get this to reproduce on GitHub Actions -- maybe the builds there differ, or maybe the builds changed since we added this fix? I'll check locally, but regardless, this is a typo.

Closes #3158.

@charliermarsh
Copy link
Member Author

Hoping (?) that the 3.13 test fails.

@charliermarsh charliermarsh changed the title Test launcher script behavior Fix venvlauncher.exe reference in venv creation Apr 20, 2024
@charliermarsh charliermarsh added bug Something isn't working windows Specific to the Windows platform labels Apr 20, 2024
@charliermarsh charliermarsh marked this pull request as ready for review April 20, 2024 14:11
@charliermarsh charliermarsh enabled auto-merge (squash) April 20, 2024 14:12
@charliermarsh charliermarsh merged commit bf10368 into main Apr 20, 2024
38 checks passed
@charliermarsh charliermarsh deleted the charlie/3.13 branch April 20, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working windows Specific to the Windows platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows scripts always uses venvwlauncher.exe
1 participant