Enforce HTTP timeouts on a per-read (rather than per-request) basis #3144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
changed the title
zanieb
approved these changes
Apr 19, 2024
|
I'd say this closes #1921 |
|
Probably fixes #2833 also |
charliermarsh
pushed a commit
that referenced
this pull request
Apr 22, 2024
Since we're now using read timeouts and not total timeouts, we can use a lower threshold, a single read shouldn't take 5 min (and not even 10s). The 10s value is somewhat arbitrary. Like #3144, this is a breaking change in some sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This leverages the new
read_timeoutproperty, which ensures that (like pip) our timeout is not applied to the entire request, but rather, to each individual read operation.Closes: #1921.
See: #1912.