Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid treating localhost URLs as local file paths #3132

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Avoid treating localhost URLs as local file paths #3132

merged 1 commit into from
Apr 19, 2024

Conversation

charliermarsh
Copy link
Member

Summary

Closes #3128.

Test Plan

  • python -m http.server
  • cargo run pip install "http://localhost:8000/werkzeug-3.0.2-py3-none-any.whl"
  • cargo run pip install "http://localhost:8000/werkzeug-3.0.2-py3-none-any.whl"

@charliermarsh charliermarsh added the bug Something isn't working label Apr 19, 2024
@charliermarsh charliermarsh marked this pull request as ready for review April 19, 2024 00:30
@charliermarsh charliermarsh enabled auto-merge (squash) April 19, 2024 00:35
@charliermarsh charliermarsh enabled auto-merge (squash) April 19, 2024 00:36
@charliermarsh charliermarsh merged commit 3c9d925 into main Apr 19, 2024
38 checks passed
@charliermarsh charliermarsh deleted the charlie/localhost branch April 19, 2024 00:37
@BrewTestBot BrewTestBot mentioned this pull request Apr 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Crash] transitive URL installs from localhost are erroneously interpreted as local paths
1 participant
@charliermarsh