Allow --python and --system on pip compile
#3115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
approved these changes
Apr 18, 2024
charliermarsh
force-pushed
the
charlie/pip-compile
branch
from
cf92324
to
428e4ef
Compare
charliermarsh
commented
Apr 18, 2024
| /// - `python3.10` or `python.exe` looks for a binary with the given name in `PATH`. | ||
| /// - `/home/ferris/.local/bin/python3.10` uses the exact Python at the given path. | ||
| #[arg(long, verbatim_doc_comment, group = "discovery")] | ||
| pub(crate) python: Option<String>, |
There was a problem hiding this comment.
Kind of wish this was -p for consistency with other commands, but --python-version is already -p.
|
Why not make these flags global instead of setting them separately for all subcommands of |
charliermarsh
pushed a commit
that referenced
this pull request
Apr 19, 2024
## Summary Following up - #3113 - #3115 It looks like `uv pip compile` command with `UV_SYSTEM_PYTHON` is missed because these two PRs are close in time. And thus resulting in ```bash $ uv --version uv 0.1.34 (9259ece 2024-04-19) $ UV_SYSTEM_PYTHON=1 uv pip compile --upgrade requirements.in -o requirements.txt error: invalid value '1' for '--system' [possible values: true, false] For more information, try '--help'. ``` Signed-off-by: Jack Cherng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I think these are useful to have for consistency, though the
--systemvariant requires some new threading.Closes: #2242.