Hide password in the index printed via --emit-index-annotation
#3112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Hide the password. | ||
| let _ = url.set_password(Some("****")); | ||
| } | ||
| writeln!(f, "{}", format!(" # from {url}").green())?; |
There was a problem hiding this comment.
Maybe we should just omit the username and password entirely -- what do you think?
There was a problem hiding this comment.
yup, that is cleaner. making the changes -
There was a problem hiding this comment.
Just moved it out to a method. Thanks!
charliermarsh
changed the title
--emit-index-annotation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
resolves #3106
Test Plan
added a simple test where the password provided in
UV_INDEX_URLis hidden in the output as expected.