Add support for .tar.bz2 source distributions #3069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Source distributions in the .tar.bz2 format are still relatively common within the existing code-bases, namely, the most common examples are the Twisted source distributions up to the version 20.3.0. As quite so often the ability to upgrade Twisted to a more recent version is not available for a given project, we add the support for .tar.bz2 here to still allow `uv` to be a drop-in replacement for `pip` in these projects.
sergeykolosov
changed the title
charliermarsh
approved these changes
Apr 16, 2024
crates/uv/tests/pip_install.rs
Outdated
| // for the given version of Python). | ||
| uv_snapshot!(context.install() | ||
| .arg("Twisted==20.3.0") | ||
| .arg("--strict"), @r###" |
There was a problem hiding this comment.
Can you change this to use --no-binary twisted, just to be sure that we aren't using the wheel? Also, can you make this a pip sync test instead to avoid the extra work downloading those other packages?
There was a problem hiding this comment.
Sure, working on it.
There was a problem hiding this comment.
Pushed the changes.
This lets us avoid the extra work downloading numerous packages Twisted depends on. Also, added `--no-binary :all:` to ensure excluding wheels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Source distributions in the .tar.bz2 format are still relatively common within the existing code-bases, namely, the most common examples are the Twisted source distributions up to the version 20.3.0. As quite so often the ability to upgrade Twisted to a more recent version is not available for a given project, we add the support for .tar.bz2 here to still allow
uvto be a drop-in replacement forpipin these projects.Test Plan
The feature was tested both by adding the corresponding test coverage, and by directly installing a package of interest under a Python version that doesn't have the corresponding wheel:
The
--no-cacheargument in the example above serves the purpose of cleaning the cached information regarding the unsatisfiability of the requirements, as it may have been cached during some previous attempt to install this package byuvversion that didn't implement this feature yet.