Add negation flags to the CLI #3050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
commented
Apr 16, 2024
| pub(crate) no_header: bool, | ||
|
|
||
| #[arg(long, overrides_with("no_header"), hide = true)] | ||
| pub(crate) header: bool, |
There was a problem hiding this comment.
These ones are a bit weird, because the hidden value is --header and the visible value (and value in the configuration file) is --no-header / no-header = true. Like, in theory it should be... --no-no-header?
charliermarsh
force-pushed
the
charlie/workspace-vi
branch
from
a2aa648
to
3a3be1e
Compare
konstin
approved these changes
Apr 16, 2024
charliermarsh
force-pushed
the
charlie/workspace-v
branch
from
d359ea8
to
986b745
Compare
charliermarsh
force-pushed
the
charlie/workspace-vi
branch
from
3a3be1e
to
e139b24
Compare
charliermarsh
force-pushed
the
charlie/workspace-v
branch
from
986b745
to
17b6acb
Compare
charliermarsh
force-pushed
the
charlie/workspace-vi
branch
2 times, most recently
from
d1273f2
to
dc8482c
Compare
charliermarsh
force-pushed
the
charlie/workspace-v
branch
from
17b6acb
to
ba0f96e
Compare
charliermarsh
force-pushed
the
charlie/workspace-vi
branch
from
dc8482c
to
2c64b96
Compare
charliermarsh
force-pushed
the
charlie/workspace-v
branch
from
ba0f96e
to
fd76507
Compare
charliermarsh
force-pushed
the
charlie/workspace-vi
branch
from
2c64b96
to
c6cb443
Compare
charliermarsh
force-pushed
the
charlie/workspace-v
branch
2 times, most recently
from
a04df02
to
78691ee
Compare
charliermarsh
force-pushed
the
charlie/workspace-vi
branch
2 times, most recently
from
d70307c
to
ae0671a
Compare
|
Added negation flags for all commands... |
charliermarsh
force-pushed
the
charlie/workspace-v
branch
from
78691ee
to
d510125
Compare
charliermarsh
force-pushed
the
charlie/workspace-vi
branch
from
ae0671a
to
27db499
Compare
charliermarsh
force-pushed
the
charlie/workspace-vi
branch
from
27db499
to
a94ac58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Now that we can pick up configuration values from persistent files, we need to enable users to disable those values from the CLI. For example, if a user has
emit_index_url = truein the configuration file, they should be able to do--no-emit-index-urlon the command-line. This PR adds support for such negations, following the same patterns we use in Ruff.