Use scheme parsing to determine absolute vs. relative URLs #2904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
commented
Apr 8, 2024
| /// | ||
| /// This is useful for parsing URLs that may be absolute or relative, with a | ||
| /// known base URL, and that doesn't require having already parsed a `BaseUrl`. | ||
| pub fn base_url_join_relative(base: &str, maybe_relative: &str) -> Result<Url, JoinRelativeError> { |
There was a problem hiding this comment.
I don't think the try behavior is necessary here. url::ParseError::RelativeUrlWithoutBase occurs if and only if the URL has no scheme... And we already verify that FileLocation::RelativeUrl is created iff the URL has no scheme.
zanieb
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We have a heuristic in
Filethat attempts to detect whether a URL is absolute or relative. However,contains("://")is prone to false positive. In the linked issues, the URLs look like:Which is relative, but includes
://.Instead, we should determine whether the URL has a scheme which matches the
Urlcrate internally.Closes #2899.