Surface invalid metadata as hints in error reports #2850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/extra
branch
from
d0b684f
to
3b609d0
Compare
charliermarsh
commented
Apr 6, 2024
charliermarsh
force-pushed
the
charlie/extra
branch
from
3b609d0
to
09a2344
Compare
charliermarsh
changed the title
charliermarsh
commented
Apr 6, 2024
| MetadataResponse::InvalidStructure(err) => { | ||
| self.unavailable_packages.insert( | ||
| package_name.clone(), | ||
| UnavailablePackage::InvalidStructure(err.to_string()), |
There was a problem hiding this comment.
It's confusing but for URLs, we don't have a version... so both UnavailablePackage and IncompletePackage have an InvalidStructure and InvalidMetadata variant.
charliermarsh
force-pushed
the
charlie/extra
branch
from
09a2344
to
62e083a
Compare
konstin
approved these changes
Apr 8, 2024
| write!( | ||
| f, | ||
| "{}{} Metadata for {} could not be parsed:\n{}", | ||
| "hint".bold().cyan(), |
There was a problem hiding this comment.
Nit: Can we move the hint: outside the match?
konstin
reviewed
Apr 8, 2024
scripts/packages/dependent_editables/second_editable/build/lib/second_editable/__init__.py
Outdated
Show resolved
Hide resolved
charliermarsh
force-pushed
the
charlie/extra
branch
from
62e083a
to
a6fa820
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2847.