Respect --no-build
and --no-binary
in --find-links
#2826
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In working on
--require-hashes
, I noticed that we're missing some incompatibility tracking for--find-links
distributions. Specifically, we don't respect--no-build
or--no-binary
, so if we select a wheel due to--find-links
, we then throw a hard error when trying to build it later (if--no-binary
is provided), rather than selecting the source distribution instead.Closes #2827.