Upgrade rs-async-zip to support data descriptors
#2809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/async-zip
branch
3 times, most recently
from
a65cd2a
to
f3b68b3
Compare
|
I've fixed all the perf regressions (and now see improvements, and significant improvements for files that use data descriptors), but I'm now seeing a very rare and sporadic "end of file" failure in some cases for files that contain data descriptors (Majored/rs-async-zip#122 (comment)). |
charliermarsh
force-pushed
the
charlie/async-zip
branch
from
f3b68b3
to
fd4c7cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Upgrading
rs-async-zipenables us to support data descriptors in streaming. This both greatly improves performance for indexes that use data descriptors and ensures that we support them in a few other places (e.g., zipped source distributions created in Finder).Closes #2808.