Preserve .git suffixes and casing in Git dependencies
#2789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/allowed-urls
branch
from
72c3cb3
to
2827bc8
Compare
charliermarsh
changed the title
.git suffixes and casing in Git dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I noticed in #2769 that I was now stripping
.gitsuffixes from Git URLs after resolving to a precise commit. This PR cleans up the internal caching to use a better canonical representation: aRepositoryUrlalong with aGitReference, instead of aGitUrlwhich can contain non-canonical data. This gives us both better fidelity (preserving the.git, along with any casing that the user provided when defining the URL) and is overall cleaner and more robust.