Use distribution database and index for all pre-resolution phases #2766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/wait
branch
from
5ee0ec4
to
2633f2a
Compare
charliermarsh
added
the
internal
charliermarsh
force-pushed
the
charlie/wait
branch
from
2633f2a
to
95d2963
Compare
charliermarsh
commented
Apr 2, 2024
| ); | ||
|
|
||
| Ok(()) | ||
| } |
There was a problem hiding this comment.
This test fails on main.
charliermarsh
force-pushed
the
charlie/wait
branch
from
95d2963
to
35962be
Compare
charliermarsh
added
bug
charliermarsh
force-pushed
the
charlie/wait
branch
from
35962be
to
569ffa1
Compare
charliermarsh
force-pushed
the
charlie/wait
branch
from
569ffa1
to
f034f76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ensures that if we resolve any distributions before the resolver, we cache the metadata in-memory.
Also ensures that we lock (important!) when resolving Git distributions.