Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't error on multiple matching index URLs #2627

Merged

Conversation

BakerNet
Copy link
Contributor

Summary

Closes Issue:

Test Plan

cargo run -- pip install -r dev-requirements.txt -r requirements.txt

where both requirements files have same --index-url

@zanieb
Copy link
Member

zanieb commented Mar 22, 2024

Could you add a test case that just uses test PyPI as the URL or something?

@zanieb zanieb added the bug Something isn't working label Mar 22, 2024
@BakerNet
Copy link
Contributor Author

Could you add a test case that just uses test PyPI as the URL or something?

Done

@charliermarsh charliermarsh force-pushed the fix/multiple-matching-index-url branch from ee62504 to d9cd56c Compare March 22, 2024 23:29
@charliermarsh charliermarsh enabled auto-merge (squash) March 22, 2024 23:29
auto-merge was automatically disabled March 22, 2024 23:31

Head branch was pushed to by a user without write access

@charliermarsh charliermarsh enabled auto-merge (squash) March 22, 2024 23:32
@charliermarsh charliermarsh merged commit a632d24 into astral-sh:main Mar 22, 2024
22 checks passed
@charliermarsh
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants