Add failing python-build-standalone alpine test #2382
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
reviewed
Mar 12, 2024
| os: [ubuntu-latest, windows-latest] | ||
| os: [ ubuntu-latest, windows-latest ] |
There was a problem hiding this comment.
What is this madness formatting? :D
There was a problem hiding this comment.
Pretter (VSCode) conflicts with this. Can you turn off formatting for YAML? I've been wondering why these change all the time :p
Maybe we should consider codifying our YAML formatting.
There was a problem hiding this comment.
(I'm not fixing this PR until the underlying bug it fixed)
zanieb
force-pushed
the
zb/system-install-alpine
branch
2 times, most recently
from
0350678
to
742c44c
Compare
8 tasks
|
@konstin what's the plan here? |
|
We need to fix musl in python-build-standalone, then we can use this branch as a test that the problem with static vs dynamic linking is indeed fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, python-build-standalone is failing on alpine (musl) with the following error:
iirc this is something that gregory mentioned, but it means that as of now, we can't adopt bootstrapping python-build-standalone as default when we want to support alpine.