Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove wheel from default PEP 517 backend #2341

Merged
merged 1 commit into from
Mar 10, 2024
Merged

Remove wheel from default PEP 517 backend #2341

merged 1 commit into from
Mar 10, 2024

Conversation

charliermarsh
Copy link
Member

Summary

This matches the latest pip and build releases. See: #2313.

Closes #2313.

@charliermarsh charliermarsh added the compatibility Compatibility with a specification or another tool label Mar 10, 2024
konstin
konstin approved these changes Mar 10, 2024
View reviewed changes
Copy link
Member

@konstin konstin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setuptools declares wheel as a wheel build dependency for PEP 517 builds already via a build hook

That's neat

@charliermarsh
Copy link
Member Author

I think we need to keep wheel when do a legacy setup.py build.

@charliermarsh charliermarsh merged commit d2d12c3 into main Mar 10, 2024
7 checks passed
@charliermarsh charliermarsh deleted the charlie/wheel branch March 10, 2024 23:34
@BrewTestBot BrewTestBot mentioned this pull request Mar 13, 2024
Merged
@covracer covracer mentioned this pull request Jun 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konstin konstin konstin approved these changes

Assignees
No one assigned
Labels
compatibility Compatibility with a specification or another tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove wheel for PEP 517 fallback builds
2 participants
@charliermarsh @konstin