Prefer more recent minor versions in wheel tags #2263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/ver
branch
from
44c4dcb
to
5c6c3d1
Compare
skshetry
approved these changes
Mar 7, 2024
charliermarsh
force-pushed
the
charlie/ver
branch
2 times, most recently
from
fe3d904
to
b134890
Compare
charliermarsh
force-pushed
the
charlie/ver
branch
from
b134890
to
8be3298
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the list of tags produced by
Tags::from_env, higher-priority tags are expected to come earlier in the list. Right now, though, we push tags likepy38beforepy312. So if you runcargo run pip install multiprocess -n --reinstall --verboseon Python 3.12, you get thepy38wheel rather than thepy32wheel.Closes #2261.