Close RECORD after reading entries during uninstall
#2259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/install
branch
4 times, most recently
from
c5e8e41
to
c208b53
Compare
charliermarsh
force-pushed
the
charlie/install
branch
from
c208b53
to
cfa6c73
Compare
|
#1830 fyi I tried this previously |
|
Thanks, this is specifically to reproduce a bug that only occurs on older Windows versions. |
charliermarsh
force-pushed
the
charlie/install
branch
4 times, most recently
from
fee6951
to
16162f9
Compare
charliermarsh
force-pushed
the
charlie/install
branch
from
16162f9
to
e4afe52
Compare
charliermarsh
changed the title
RECORD after reading entries during uninstall
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It turns out that by keeping the
RECORDfile open, older versions of Windows mark it for deletion, but don't allow it to be deleted until it's closed. As such, we end up leaving the.dist-infodirectory around, since it appears non-empty; but once the program terminates, we do deleteRECORD, leaving it empty. This then creates the impression that a package exists where it does not.Closes #2074.