Respect non-sysconfig-based system Pythons
#2193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/venv-paths
branch
from
b58858e
to
36fde0e
Compare
charliermarsh
changed the title
get_interpreter_info.py to respect non-sysconfig-based system Pythons
charliermarsh
changed the title
get_interpreter_info.py to respect non-sysconfig-based system Pythonssysconfig-based system Pythons
charliermarsh
added
bug
charliermarsh
force-pushed
the
charlie/sysconfig-paths
branch
2 times, most recently
from
d28e570
to
fcf9a3f
Compare
charliermarsh
force-pushed
the
charlie/venv-paths
branch
from
36fde0e
to
26263f1
Compare
charliermarsh
force-pushed
the
charlie/sysconfig-paths
branch
3 times, most recently
from
5f4328d
to
fada08d
Compare
konstin
approved these changes
Mar 5, 2024
charliermarsh
force-pushed
the
charlie/sysconfig-paths
branch
from
fada08d
to
195f6b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
pipusessysconfigfor Python 3.10 and later by default; however, it falls back todistutilsfor earlier Python versions, and distros can actually tellpipto continue falling back todistutilsvia the_PIP_USE_SYSCONFIGvariable.By always using
sysconfig, we're doing the wrong then when installing into some system Pythons, e.g., on Debian prior to Python 3.10.This PR modifies our logic to mirror
pipexactly, which is what's been recommended to me as the right thing to do.Closes #2113.
Test Plan
Most notably, the new Debian tests pass here (which fail on main: #2144).
I also added Pyston as a second stress-test.