Repository navigation
Prefer python over python3 in Unix environments
#21559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
37ff7bc
cecc43c
8535480
c1e590a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9155,7 +9155,7 @@ fn sync_invalid_environment() -> Result<()> { | |
| uv_snapshot!(context.filters(), context.sync(), @" | ||
| exit_code: 0 (success) | ||
| ----- stderr ----- | ||
| warning: Ignoring existing virtual environment linked to non-existent Python interpreter: .venv/[BIN]/[PYTHON] -> python | ||
| warning: Ignoring existing virtual environment linked to non-existent Python interpreter: .venv/[BIN]/[PYTHON] -> does-not-exist | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Intriguing... The test looked more wrong before than it does now. So if a symlink is pointing at a broken symlink we do not print the final broken target, but rather the intermediate (working) target? Also weird that we don't print a full path? I guess this avoids dealing with loops and such. Oh well. Not important for this PR... |
||
| Using CPython 3.12.[X] interpreter at: [PYTHON-3.12] | ||
| Removed virtual environment at: .venv | ||
| Creating virtual environment at: .venv | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment explains (maybe not that clearly, but it could just be me) what the next two lines are trying to do. But then there are no more comments for the remaining snapshots. I feel they help a lot.
It could just be
// Environments containing onlypython3remain supportedleading in for both with the blank line between them removed.We actually don't test the case without
.arg(context.venv.path())forpythonabove.