Repository navigation
Separate metadata and archive hash policies - #21549
Merged
Merged
Conversation
charliermarsh
had a problem deploying
to
automations
September 9, 2026 00:38 — with 
GitHub Actions
Error
GitHub Actions
Error
charliermarsh
added this pull request to stack #21550
September 9, 2026 00:40
charliermarsh
force-pushed
the
charlie/separate-metadata-hash-policy
branch
from
September 9, 2026 00:47
f8a2d37 to
58f33c1
Compare
charliermarsh
had a problem deploying
to
automations
September 9, 2026 00:49 — with
GitHub Actions
Error
GitHub Actions
Error
charliermarsh
force-pushed
the
charlie/separate-metadata-hash-policy
branch
from
September 9, 2026 00:50
58f33c1 to
9f01084
Compare
charliermarsh
temporarily deployed
to
automations
September 9, 2026 00:52 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
charliermarsh
force-pushed
the
charlie/separate-metadata-hash-policy
branch
from
September 9, 2026 01:10
9f01084 to
651738f
Compare
charliermarsh
changed the title
charliermarsh
had a problem deploying
to
automations
September 9, 2026 01:11 — with
GitHub Actions
Error
GitHub Actions
Error
charliermarsh
force-pushed
the
charlie/separate-metadata-hash-policy
branch
from
September 9, 2026 01:18
651738f to
41dda0e
Compare
charliermarsh
temporarily deployed
to
automations
September 9, 2026 01:19 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
charliermarsh
added
the
internal
zanieb
reviewed
Sep 9, 2026
| /// The context in which hashes should be generated. | ||
| /// Hash requirements accompanying a distribution metadata lookup. | ||
| /// | ||
| /// These concern the distribution archive, not a hash of the metadata. |
Member
Author
There was a problem hiding this comment.
Are you commenting on the way it's phrased, or the actual content of what it's saying?
Member
There was a problem hiding this comment.
Sorry just driving by randomly at night... uhh I'm confused that it says this on the MetadataHashRequest and don't understand what it means in that context
uv test inventory changesThis PR changes the tests when compared with the
|
charliermarsh
force-pushed
the
charlie/separate-metadata-hash-policy
branch
from
September 9, 2026 01:48
41dda0e to
dcd65a2
Compare
charliermarsh
temporarily deployed
to
automations
September 9, 2026 01:49 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
EliteTK
self-requested a review
September 9, 2026 21:34
EliteTK
approved these changes
Sep 9, 2026
EliteTK
left a comment
EliteTK
left a comment
Member
There was a problem hiding this comment.
I think maybe if the naming was "...Policy" rather than "...Request" then this would be better. I still think this stuff is confusing, but I'd say that this does seem like somewhat of an improvement.
I haven't seen the follow up PR yet so this stuff might make more sense later.
| #[derive(Debug, Default, Clone, Copy, PartialEq, Eq)] | ||
| pub struct MetadataHashRequest<'a> { | ||
| /// Which missing hashes to collect for the resolution. | ||
| pub collection: Option<HashCollection>, |
Member
There was a problem hiding this comment.
pre-existing: It feels kind of weird that we have some things with ::None variants and here HashCollection doesn't and ends up in an Option.
charliermarsh
force-pushed
the
charlie/separate-metadata-hash-policy
branch
from
September 10, 2026 00:34
dcd65a2 to
1e491b4
Compare
charliermarsh
changed the title
charliermarsh
temporarily deployed
to
automations
September 10, 2026 00:35 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HashPolicycurrently carries both resolution-wide hash collection settings and requirements for a specific archive. We split those intoMetadataHashPolicy, with collection and validation fields, andArchiveHashPolicy, which describes the hashes an archive must provide.The distribution database selects the archive policy. Expected hashes continue to take precedence over collection.
Preparation for #21279, which adds URL-hash reuse on top of this refactor.