Repository navigation
Prefetch wheel central directories for streamed file publication - #21338
Draft
charliermarsh wants to merge 22 commits into
Draft
charliermarsh wants to merge 22 commits into
charliermarsh wants to merge 22 commits into
Conversation
charliermarsh
had a problem deploying
to
automations
August 28, 2026 11:40 — with
GitHub Actions
Failure
charliermarsh
force-pushed
the
charlie/dirhash-all-files
branch
2 times, most recently
from
August 31, 2026 12:59
73c621b to
87bd56f
Compare
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Alternative to #21334 and #21333, stacked on #21327.
We fetch the ZIP central directory with range requests before streaming extraction, so we know each
file's executable status as soon as its payload is unpacked. We set its permissions while the file
is still private, then publish it to
files-v0through a bounded queue while the remaining payloadsdownload and extract. File hashes still include executable status, and installation keeps its
existing link behavior; we don't need permission manifests or copies to restore executable bits.
We start with a 16 KiB suffix request and fetch more of the directory when needed. Strong ETags from
the full response are sent as
If-Matchon the range requests. If prefetching fails, we fall backto learning modes from the streamed directory and publishing files then.
The full streamed ZIP is still validated before we expose the archive. If its executable modes
differ from the prefetched directory, we reject the download without changing any shared inode's
permissions.
RECORDstays private. Rejected or interrupted downloads can leave orphan fileobjects, which cache pruning removes.
This adds range requests to cold downloads. I haven't measured whether the overlap outweighs that
cost yet.