Repository navigation
Share downloaded URL wheels across hash fragments - #21288
Draft
charliermarsh wants to merge 7 commits into
Draft
charliermarsh wants to merge 7 commits into
charliermarsh wants to merge 7 commits into
Conversation
charliermarsh
temporarily deployed
to
automations
August 24, 2026 16:04 — with
GitHub Actions
Inactive
charliermarsh
marked this pull request as ready for review
August 24, 2026 16:22
Member
|
That's the same as #21210, though I don't mind which one we merge. |
charliermarsh
temporarily deployed
to
automations
August 24, 2026 18:31 — with
GitHub Actions
Inactive
Merging this PR will improve performance by 8.55%
Performance Changes
Tip Curious why performance improved? Comment Comparing Footnotes
|
charliermarsh
temporarily deployed
to
automations
August 24, 2026 18:55 — with
GitHub Actions
Inactive
charliermarsh
temporarily deployed
to
automations
August 24, 2026 19:16 — with
GitHub Actions
Inactive
charliermarsh
temporarily deployed
to
automations
August 24, 2026 19:36 — with
GitHub Actions
Inactive
charliermarsh
marked this pull request as draft
August 24, 2026 21:43
charliermarsh
removed this pull request from stack #21289
September 9, 2026 00:39
charliermarsh
added this pull request to stack #21550
September 9, 2026 00:40
charliermarsh
force-pushed
the
charlie/normalize-wheel-cache-hashes
branch
from
September 10, 2026 14:58
107ee98 to
3311391
Compare
charliermarsh
temporarily deployed
to
automations
September 10, 2026 14:59 — with
GitHub Actions
Inactive
charliermarsh
temporarily deployed
to
automations
September 10, 2026 15:20 — with
GitHub Actions
Inactive
uv test inventory changesThis PR changes the tests when compared with the
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We omit known hash fields from
CanonicalUrl, preserving source selectors and unknown fragments, and index downloaded URL wheels by their canonical URL and computed hashes. This letsuv sync --offlinereuse a wheel downloaded from a fragment-hashed URL when the lockfile stores its URL and hashes separately.Keep HTTP metadata, source builds, and in-flight downloads scoped to their original hash declarations. Sharing checks the complete hash policy and reads metadata from the selected archive, so a newer revision cannot hide an older cached wheel or pair new wheel bytes with old metadata. Existing cache keys remain valid, and references to older revisions survive cache pruning.
Apply the same filename, hash, size, and archive-existence checks to every cached URL wheel candidate. When online, refresh cached contents that no longer match the requested hashes or size before resolving dependencies. Fresh integrity failures are rejected without an extra retry, including in the full-download fallback.
Follows #21279, which added URL hash reuse during resolution.