Repository navigation
remove support for pyx-specific .whl.tar.zst format #21184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -35,6 +35,9 @@ pub struct File { | |
| pub upload_time_utc_ms: Option<i64>, | ||
| pub url: FileLocation, | ||
| pub yanked: Option<Box<Yanked>>, | ||
| /// Deprecated pyx-specific zstd wheel metadata, retained only for compatibility with the | ||
| /// flat-index cache layout. | ||
| // TODO: Remove this field when the flat-index cache format is next bumped. | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Decided not to remove this key as it would require churning all users' caches, even if they weren't pyx users. If cache churn is acceptable, this PR can be simplified a bit. |
||
| pub zstd: Option<Box<Zstd>>, | ||
| } | ||
|
|
||
|
|
@@ -253,6 +256,9 @@ pub enum ToUrlError { | |
| }, | ||
| } | ||
|
|
||
| /// Deprecated pyx-specific zstd wheel metadata, retained only for compatibility with existing | ||
| /// cache layouts. | ||
| // TODO: Remove this type once the Simple API and flat-index cache formats are both bumped. | ||
| #[derive(Debug, Clone, PartialEq, Eq, Hash, rkyv::Archive, rkyv::Deserialize, rkyv::Serialize)] | ||
| pub struct Zstd { | ||
| pub hashes: HashDigests, | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Decided not to remove this key as it would require churning all users' caches, even if they weren't pyx users. If cache churn is acceptable, this PR can be simplified a bit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoiding the churn seems fine to me!