Better offline error message #2110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error for `uv pip compile scripts/requirements/jupyter.in` without internet: **Before** ``` error: error sending request for url (https://pypi.org/simple/jupyter/): error trying to connect: dns error: failed to lookup address information: Temporary failure in name resolution Caused by: error trying to connect: dns error: failed to lookup address information: Temporary failure in name resolution Caused by: dns error: failed to lookup address information: Temporary failure in name resolution Caused by: failed to lookup address information: Temporary failure in name resolution ``` **After** ``` error: error sending request for url (https://pypi.org/simple/jupyter/): error trying to connect: dns error: No such host is known. (os error 11001) Caused by: Could not connect, are you offline? ``` The implementation checks for "dne error" stringly as hyper errors are opaque. The danger is that this breaks with a hyper update. We still get the complete error trace since reqwest eagerly inlines errors (seanmonstar/reqwest#2147). No test since i wouldn't know how to simulate this in cargo test. Fixes #1971
|
Isn't the error / caused by out of order here? |
|
Yeah, will switch. The feature i really want is to attach hints to error messages that are shown below the error chain themselves. I also want that for build errors (#2108). We could do that by defining our own |
|
I've switched the error hierarchy, it's verbose again. I've experimented a bit with adding help messages but i don't think it's possible without either adding that trait to our entire error hierarchy (the miette approach) or losing the error type in a |
zanieb
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error for
uv pip compile scripts/requirements/jupyter.inwithout internet:Before
After
On linux, it would be "Temporary failure in name resolution" instead of "No such host is known. (os error 11001)".
The implementation checks for "dne error" stringly as hyper errors are opaque. The danger is that this breaks with a hyper update. We still get the complete error trace since reqwest eagerly inlines errors (seanmonstar/reqwest#2147).
No test since i wouldn't know how to simulate this in cargo test.
Fixes #1971