Repository navigation
Use linux-raw-sys for FIEMAP constants - #21056
Merged
Merged
Conversation
EliteTK
force-pushed
the
tk/cleanup-fiemap-constants
branch
from
August 11, 2026 17:26
230149e to
3e0c670
Compare
|
I'm having the following error on loongarch64-linux: error[E0432]: unresolved imports `linux_raw_sys::ioctl::FIEMAP_EXTENT_DATA_INLINE`, `linux_raw_sys::ioctl::FIEMAP_EXTENT_DELALLOC`, `linux_raw_sys::ioctl::FIEMAP_EXTENT_ENCODED`, `linux_raw_sys::ioctl::FIEMAP_EXTENT_LAST`, `linux_raw_sys::ioctl::FIEMAP_EXTENT_NOT_ALIGNED`, `linux_raw_sys::ioctl::FIEMAP_EXTENT_SHARED`, `linux_raw_sys::ioctl::FIEMAP_EXTENT_UNKNOWN`
--> crates/uv-fs/src/space.rs:13:5
|
13 | FIEMAP_EXTENT_DATA_INLINE, FIEMAP_EXTENT_DELALLOC, FIEMAP_EXTENT_ENCODED, FIEMAP_EXTENT_LAST,
| ^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^ no `FIEMAP_EXTENT_LAST` in `ioctl`
| | | |
| | | no `FIEMAP_EXTENT_ENCODED` in `ioctl`
| | no `FIEMAP_EXTENT_DELALLOC` in `ioctl`
| no `FIEMAP_EXTENT_DATA_INLINE` in `ioctl`
14 | FIEMAP_EXTENT_NOT_ALIGNED, FIEMAP_EXTENT_SHARED, FIEMAP_EXTENT_UNKNOWN, FS_IOC_FIEMAP,
| ^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ no `FIEMAP_EXTENT_UNKNOWN` in `ioctl`
| | |
| | no `FIEMAP_EXTENT_SHARED` in `ioctl`
| no `FIEMAP_EXTENT_NOT_ALIGNED` in `ioctl`It seems that constants like |
Member
|
loong64 isn't one of the platforms we build or test for. Can you explain how you're doing the build? |
|
I build with Nix on my machines, and the command should look something like It seems that sunfishcode/linux-raw-sys#193 or sunfishcode/linux-raw-sys#195 should fix this on the |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a follow up to #20925, it makes use of the linux-raw-sys crate which is already in our dependency graph and has the constants which we were previously declaring inline. This doesn't really affect the amount of code, but it avoids needing to think about these values.
Test Plan
Existing coverage.