Repository navigation
Use Lock::from_toml consistently, check version - #20924
Merged
Merged
Conversation
Signed-off-by: William Woodruff <william@yossarian.net>
charliermarsh
approved these changes
Aug 3, 2026
woodruffw
commented
Aug 3, 2026
Signed-off-by: William Woodruff <william@yossarian.net>
Member
Author
|
Sorry, re-requesting review since I changed the approach 😅 |
Lock::from_toml consistently, check version
uv test inventory changesThis PR changes the tests when compared with the
|
zsol
approved these changes
Aug 4, 2026
zsol
left a comment
Member
There was a problem hiding this comment.
thanks, this looks great! Gotta make sure the pub fields we just hid aren't used by known projects that use our crates
Member
Author
|
Took a quick look at the reverse deps on crates.io and couldn't find any third-party users of |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
See #20921 (comment) for context.
This accomplishes two goals:
uv toolsubcommands, which is consistent with what the project commands doTest Plan
Added a test demonstrating the change. The behavior from the change is arguably surprising, though:
ToolLock::readsilently skips the lockfile if it's invalid, which includes our new version check. Arguably that should be stronger, i.e. we should reject if the lockfile is malformed (or at least warn?).