Contain nested wheel-data symlinks - #20431
Open
zanieb wants to merge 1 commit into
Open
Conversation
uv test inventory changesThis PR changes the tests when compared with the latest
|
konstin
approved these changes
Jul 21, 2026
| if entry.file_type().is_symlink() | ||
| && let Some((exclude_matcher, source_tree)) = exclude_matcher | ||
| { | ||
| let canonical_source_tree = source_tree.simple_canonicalize()?; |
| /// Either an absolute path or a parent path through `..`. | ||
| #[error("The path for the data directory {} must be inside the project: {}", name, path.user_display())] | ||
| InvalidDataRoot { name: String, path: PathBuf }, | ||
| #[error("The path for the data file must be inside the project: {}", _0.user_display())] |
Member
There was a problem hiding this comment.
Suggested change
| #[error("The path for the data file must be inside the project: {}", _0.user_display())] | |
| #[error("The data file is a link to a file outside the project: {}", _0.user_display())] |
Member
|
I hope nobody uses this for something like including data files from elsewhere in the repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A nested symlink beneath
tool.uv.build-backend.datacan package files outside the source tree or files excluded from the source and wheel, even after the data root is contained. Resolve each data file against the source tree, reject escaped targets, and apply both exclusion sets before adding it to the wheel.#20397 contained data roots but left this nested-symlink path open. #15243 documents that the backend already follows external file symlinks, so this closes that path into an artifact.