Skip to content

Avoid redundant direct URL clones #20207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zanieb merged 1 commit into from
Jul 7, 2026
Merged

Avoid redundant direct URL clones #20207

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/uv-distribution-types/src/requirement.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1145,7 +1145,7 @@ impl TryFrom<RequirementSourceWire> for RequirementSource {
let location = url.clone();

// Create a PEP 508-compatible URL.
let mut url = url.clone();
let mut url = url;
if let Some(subdirectory) = &subdirectory {
url.set_fragment(Some(&format!("subdirectory={subdirectory}")));
}
Expand All @@ -1155,7 +1155,7 @@ impl TryFrom<RequirementSourceWire> for RequirementSource {
subdirectory: subdirectory.map(Box::<Path>::from),
ext: DistExtension::from_path(url.path())
.map_err(|err| ParsedUrlError::MissingExtensionUrl(url.to_string(), err))?,
url: VerbatimUrl::from_url(url.clone()),
url: VerbatimUrl::from_url(url),
})
}
// TODO(charlie): The use of `CWD` here is incorrect. These should be resolved relative
Expand Down
Loading