Skip to content

Refactor guarded reads with ValidatedReader - #20150

Merged
zanieb merged 1 commit into
mainfrom
zb/validated-reader-builder
Jul 6, 2026
Merged

Refactor guarded reads with ValidatedReader#20150
zanieb merged 1 commit into
mainfrom
zb/validated-reader-builder

Conversation

@zanieb

@zanieb zanieb commented Jul 6, 2026

Copy link
Copy Markdown
Member

Amends the implementation in #20099 to use a reusable builder pattern instead of a special "utf-8 with prefix validation" function.

@astral-sh-bot

astral-sh-bot Bot commented Jul 6, 2026

Copy link
Copy Markdown

uv test inventory changes

This PR changes the tests when compared with the latest zsol/list-scripts baseline.

  • Added tests: 1
  • Removed tests: 7
  • Changed suites: 5
uv-fs: +1 / -0

Added:

  • uv-fs::read::tests::reads_without_utf_8_validation

Removed: none

uv-installer: +0 / -1

Added: none

Removed:

  • uv-installer::site_packages::tests::sorted_dist_like_paths_filters_and_sorts
uv-workspace: +0 / -2

Added: none

Removed:

  • uv-workspace::pyproject_mut::test::add_index_preserves_format_when_windows_path_unchanged
  • uv-workspace::pyproject_mut::test::add_index_syncs_format_on_url_update
uv::it: +0 / -1

Added: none

Removed:

  • uv::it::network::retry_read_timeout_python_downloads_json
uv::project: +0 / -3

Added: none

Removed:

  • uv::project::edit::add_index_with_existing_relative_path_in_script
  • uv::project::export::pep_751_no_packages
  • uv::project::export::requirements_txt_conditional_transitive_extra

@codspeed-hq

codspeed-hq Bot commented Jul 6, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 22 untouched benchmarks


Comparing zb/validated-reader-builder (9b38b94) with main (93ae523)

Open in CodSpeed

@zanieb
zanieb force-pushed the zb/validated-reader-builder branch from 52c6850 to f651a53 Compare July 6, 2026 18:06
@zanieb
zanieb marked this pull request as ready for review July 6, 2026 18:10
@zanieb zanieb added the internal A refactor or improvement that is not user-facing label Jul 6, 2026
Base automatically changed from zsol/list-scripts to main July 6, 2026 18:54
@zanieb
zanieb force-pushed the zb/validated-reader-builder branch from f651a53 to 9b38b94 Compare July 6, 2026 19:20
@zanieb
zanieb merged commit bf58c06 into main Jul 6, 2026
55 checks passed
@zanieb
zanieb deleted the zb/validated-reader-builder branch July 6, 2026 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal A refactor or improvement that is not user-facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant