Skip to content

Ensure that incompatible wheel hints do not leak secrets #19504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zanieb merged 1 commit into from
May 20, 2026
Merged

Ensure that incompatible wheel hints do not leak secrets #19504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions crates/uv-installer/src/plan.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ use anyhow::{Result, bail};
use owo_colors::OwoColorize;
use tracing::{debug, warn};

use url::Url;
use uv_cache::{Cache, CacheBucket, WheelCache};
use uv_cache_info::Timestamp;
use uv_configuration::{BuildOptions, Reinstall};
Expand All @@ -24,6 +23,7 @@ use uv_normalize::PackageName;
use uv_platform_tags::{AbiTag, IncompatibleTag, LanguageTag, PlatformTag, TagCompatibility, Tags};
use uv_pypi_types::VerbatimParsedUrl;
use uv_python::PythonEnvironment;
use uv_redacted::DisplaySafeUrl;
use uv_types::HashStrategy;

use crate::satisfies::RequirementSatisfaction;
Expand All @@ -40,7 +40,7 @@ pub struct IncompatibleWheelError {

#[derive(Debug)]
enum IncompatibleWheelKind {
Url(Url),
Url(DisplaySafeUrl),
Path(PathBuf),
}

Expand Down Expand Up @@ -422,7 +422,7 @@ impl<'a> Planner<'a> {
Dist::Built(BuiltDist::DirectUrl(wheel)) => {
if !wheel.filename.is_compatible(tags) {
return Err(IncompatibleWheelError {
kind: IncompatibleWheelKind::Url(wheel.url.to_url().into()),
kind: IncompatibleWheelKind::Url(wheel.url.to_url()),
compatibility_hint: generate_wheel_compatibility_hint(
&wheel.filename,
tags,
Expand Down
27 changes: 27 additions & 0 deletions crates/uv/tests/it/pip_sync.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6428,6 +6428,33 @@ fn incompatible_python_version_direct_url() -> Result<()> {
Ok(())
}

#[test]
fn incompatible_direct_url_redacts_credentials() -> Result<()> {
let context = uv_test::test_context!("3.12");

let requirements_txt = context.temp_dir.child("requirements.txt");
requirements_txt.write_str("numpy @ https://user:secret@files.pythonhosted.org/packages/ae/11/7c546fcf42145f29b71e4d6f429e96d8d68e5a7ba1830b2e68d7418f0bbd/numpy-2.3.2-cp313-cp313-win32.whl?X-Amz-Signature=signing-secret")?;

uv_snapshot!(context.filters(), context.pip_sync()
.arg("requirements.txt")
.arg("--python-platform")
.arg("windows"), @"
success: false
exit_code: 2
----- stdout -----

----- stderr -----
Resolved 1 package in [TIME]
error: Failed to determine installation plan
Caused by: A URL (https://user:****@files.pythonhosted.org/packages/ae/11/7c546fcf42145f29b71e4d6f429e96d8d68e5a7ba1830b2e68d7418f0bbd/numpy-2.3.2-cp313-cp313-win32.whl?X-Amz-Signature=****) dependency is incompatible with the current platform

hint: The wheel is compatible with CPython 3.13 (`cp313`), but you're using CPython 3.12 (`cp312`)
"
);

Ok(())
}

#[test]
fn incompatible_platform_direct_url() -> Result<()> {
let context = uv_test::test_context!("3.13");
Expand Down
Loading