Skip to content

Rewrite the native authentication storage scheme - #18907

Draft
zanieb wants to merge 13 commits into
mainfrom
zb/native-auth-as-json
Draft

Rewrite the native authentication storage scheme#18907
zanieb wants to merge 13 commits into
mainfrom
zb/native-auth-as-json

Conversation

@zanieb

@zanieb zanieb commented Apr 7, 2026

Copy link
Copy Markdown
Member

No description provided.

oshadha-dev

This comment was marked as low quality.

@nooscraft

Copy link
Copy Markdown
Contributor

Sorry for the confusion - I'm @oshadha-dev and was using an assistant to help review the code. The approval was submitted in error. I was analyzing the PR but the formal approval should not have been submitted. Please disregard it!

@nooscraft

Copy link
Copy Markdown
Contributor

Hey @zanieb - the implementation looks good and should fix the artifactory issue.

(Apologies for the accidental approval earlier - that was submitted in error)

@codspeed-hq

codspeed-hq Bot commented Jun 10, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 14 untouched benchmarks


Comparing zb/native-auth-as-json (522a36e) with main (f7d86ee)

Open in CodSpeed

@zanieb
zanieb force-pushed the zb/native-auth-as-json branch 3 times, most recently from c5205f0 to 1c0a9b3 Compare June 10, 2026 16:01
@astral-sh-bot

astral-sh-bot Bot commented Jun 10, 2026

Copy link
Copy Markdown

uv test inventory changes

This PR changes the tests when compared with the latest main baseline.

  • Added tests: 24
  • Removed tests: 0
  • Changed suites: 4
uv-auth: +20 / -0

Added:

  • uv-auth::keyring::tests::legacy_service_names_http_include_scheme_host
  • uv-auth::keyring::tests::legacy_service_names_https_include_url_and_host
  • uv-auth::keyring::tests::native_exact_service_precedes_prefix_ambiguity
  • uv-auth::keyring::tests::native_fetch_does_not_migrate_legacy_host_entry_to_http
  • uv-auth::keyring::tests::native_fetch_keeps_legacy_full_url_scope_exact
  • uv-auth::keyring::tests::native_fetch_migrates_legacy_host_entry_on_first_use
  • uv-auth::keyring::tests::native_fetch_migrates_legacy_host_entry_with_port
  • uv-auth::keyring::tests::native_fetch_prefers_legacy_scheme_host_for_http
  • uv-auth::keyring::tests::native_fetch_waits_for_concurrent_write
  • uv-auth::keyring::tests::native_migration_does_not_restore_removed_legacy_credential
  • uv-auth::keyring::tests::native_more_specific_match_wins_over_less_specific_ambiguity
  • uv-auth::keyring::tests::native_remove_does_not_remove_realm_root_fallback
  • uv-auth::keyring::tests::native_remove_keeps_current_credential_when_legacy_cleanup_fails
  • uv-auth::keyring::tests::native_remove_removes_all_matching_legacy_entries
  • uv-auth::keyring::tests::native_remove_removes_legacy_host_entry
  • uv-auth::keyring::tests::native_store_serializes_concurrent_updates
  • uv-auth::matching::tests::credential_matches_rejects_sibling_paths
  • uv-auth::matching::tests::path_prefix_matches_respects_segment_boundaries
  • uv-auth::store::tests::test_more_specific_match_wins_over_less_specific_ambiguity
  • uv-auth::store::tests::test_prefix_matching_respects_path_boundaries

Removed: none

uv-auth::native_windows: +1 / -0

Added:

  • uv-auth::native_windows::native_store_enumerates_many_credentials_in_one_realm

Removed: none

uv-keyring: +1 / -0

Added:

  • uv-keyring::windows::tests::test_enumerate_target_prefix

Removed: none

uv::it: +2 / -0

Added:

  • uv::it::auth::native_auth_logout_is_service_scoped
  • uv::it::auth::native_auth_multiple_users

Removed: none

Comment thread crates/uv-auth/src/keyring.rs Outdated
Comment thread crates/uv-auth/src/keyring.rs Outdated
Comment thread crates/uv-auth/src/keyring.rs Outdated
Comment thread crates/uv-auth/src/keyring.rs Outdated
Comment thread crates/uv-auth/src/keyring.rs Outdated
Comment thread crates/uv-auth/src/keyring.rs Outdated
Comment thread crates/uv-auth/src/keyring.rs Outdated
Comment thread crates/uv-auth/src/keyring.rs Outdated
Comment thread crates/uv-auth/src/keyring.rs Outdated
@zanieb
zanieb force-pushed the zb/native-auth-as-json branch from 1f465dc to 9d7f18b Compare June 11, 2026 04:32
Comment thread crates/uv-auth/src/keyring/native/collection.rs Outdated
Comment thread crates/uv-auth/src/keyring/native/collection.rs Outdated
Comment thread crates/uv-auth/src/keyring/native/collection.rs Outdated
Comment thread crates/uv-auth/src/keyring/native/collection.rs Outdated
Comment thread crates/uv-auth/src/keyring/native.rs Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants