Fix windows py spurious stderr failure #1885
Conversation
|
(Would be good to get eyes on this from whoever wrote it, to know why it was here in the first place.) |
|
We had similar logic like this in the LSP? I feel like it's bad form to use content in stderr as a bad exit. I agree it'd be nice to get another review. |
|
Agree. |
| @@ -344,8 +344,8 @@ mod windows { | |||
| .in_scope(|| Command::new("py").arg("--list-paths").output()) | |||
| .map_err(Error::PyList)?; | |||
|
|
|||
| // There shouldn't be any output on stderr. | |||
| if !output.status.success() || !output.stderr.is_empty() { | |||
| // `py` sometimes prints "Installed Pythons found by py Launcher for Windows" to stderr which we ignore. | |||
There was a problem hiding this comment.
That's funny that it only does this sometimes. I tried to reproduce this on my machine with the official py launcher and never managed to get it write to stderr.
I don't mind the change but we may want to log the stderr output with tracing::debug!() if it's non empty. It might be helpful when debugging issues related to py.
There was a problem hiding this comment.
It's consistent on my machine; I meant "sometimes" as in depending on which windows box you're on.
My py does this in a command window as well as bash (mingw).
This was just defensive programming |
Summary
On Windows
10.0.19045thepycommand prints tostderreven when working correctly. This means that uv should not treat this as a failure.Fixes #1904
Test Plan
I ran the modified code and it worked. I expect the pull request to run automated tests.