Remove --upgrade and --quiet flags from generated output files
#1873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yasufumy
force-pushed
the
fix/pip-tools-compatibility
branch
from
1e64d71
to
06273e7
Compare
yasufumy
commented
Feb 23, 2024
| @@ -393,7 +404,13 @@ pub(crate) async fn pip_compile( | |||
| } | |||
|
|
|||
| /// Format the `uv` command used to generate the output file. | |||
| fn cmd(include_index_url: bool, include_find_links: bool) -> String { | |||
| #[allow(clippy::fn_params_excessive_bools)] | |||
There was a problem hiding this comment.
I'm new to Rust and I didn't come up with a good idea to avoid the clippy warning. I'd appreciate it if you suggest a better way.
There was a problem hiding this comment.
I think what you have here is ok!Tthough I'm gonna remove the arguments because I think we should just always omit these.
There was a problem hiding this comment.
Okay! Thank you for your comment.
charliermarsh
approved these changes
Feb 23, 2024
|
Thanks @yasufumy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolve #1814
I changed the behavior of
pip compileto not display--upgrade(-U) and--quiet(-q) for compatibility