Retain relative paths in the lock file for file:///${PROJECT_ROOT}/...#18678
Closed
zanieb wants to merge 3 commits intoastral-sh:mainfrom
Closed
Retain relative paths in the lock file for file:///${PROJECT_ROOT}/...#18678zanieb wants to merge 3 commits intoastral-sh:mainfrom
file:///${PROJECT_ROOT}/...#18678zanieb wants to merge 3 commits intoastral-sh:mainfrom
Conversation
File URL dependencies containing environment variable references (e.g.,
`file:///${PROJECT_ROOT}/a`) should produce relative paths in lockfiles,
since the user is parameterizing the path for portability. Previously,
`was_given_absolute()` treated all file URLs as absolute, causing these
paths to be stored as absolute in the lockfile after PR astral-sh#18176.
https://claude.ai/code/session_018jGTUmqEdwKfaWo1zQ9jWW
Member
Author
|
Replaced by #18680 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the regression at #18176 (comment)