Conversation
charliermarsh
approved these changes
Mar 13, 2026
Member
|
Oh wait so this should fail today? |
Member
Author
|
It didn't run because of #18465 |
zanieb
commented
Mar 14, 2026
Installs greenlet with --only-binary on macos-15-intel with conda. Without SYSTEM_VERSION_COMPAT=0, conda's Python reports macosx_10_16 platform tags due to Apple's compat shim, so the macosx_11_0_universal2 wheel won't match and the install fails.
greenlet 3.0.x has macosx_10_9 wheels for cp312, which match even with broken 10.16 tags. From 3.1.0 onward, only macosx_11_0_universal2 wheels are available, so the test properly fails without the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproduces #14267 — see https://github.com/astral-sh/uv/actions/runs/23076175099/job/67037153580
Which is resolved by #18452 — see https://github.com/astral-sh/uv/actions/runs/23090030294/job/67074278041