-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Improve reporting of managed interpreter symlinks in uv python list
#18459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+79
−2
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
0e37886
Show managed symlinks with `uv python list --managed-python`
claude d8137e0
Also filter managed interpreters from `--no-managed-python` output
claude 812307e
Make match exhaustive and inline discovery_preference
claude ad3e7c3
Replace managed symlinks test with real python install test
claude 67d780c
Apply suggestion from @zanieb
zanieb 0c67e62
Apply suggestion from @zanieb
zanieb f5b994d
Merge branch 'main' into 18459-claude-fix-uv-17959-hj6Pq
zanieb d2dad35
Fix snapshot tests: use [LATEST] filter for 3.10 patch versions
zanieb 91a33c2
Restrict python_list_managed_symlinks test to Unix (no symlinks on Wi…
zanieb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this just be
python_preference.allows(installation.source)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, here we want to check if the installation is managed regardless of the source, so we need to actually check where interpreter's base prefix is. It does seem like
PythonPreference::allows_interpreterwould be useful though.