Improve error handling for platform detection in Python downloads#18453
Merged
zanieb merged 1 commit intoastral-sh:mainfrom Mar 13, 2026
Merged
Conversation
…n failures
When `Platform::from_env()` fails due to libc detection (e.g., unable to
read ELF interpreter), the error was wrapped as `InvalidRequestPlatform`
("Failed to parse request part") via the blanket `#[from] platform::Error`
conversion. This is misleading because the failure is about detecting the
system's libc, not parsing a user request.
Route `LibcDetectionError` variants to the existing `LibcDetection` error
variant which has the correct message: "Failed to determine the libc used
on the current platform".
https://claude.ai/code/session_01YGKULoskvxdzhTShfgjM3r
charliermarsh
approved these changes
Mar 13, 2026
zaniebot
force-pushed
the
claude/fix-elf-interpreter-error-BWD1h
branch
from
819bd85 to
8582ac2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed this weird error chain in #8635 (comment)