fix: ignore empty SSL_CERT_FILE environment variable#18426
Closed
1cbyc wants to merge 1 commit intoastral-sh:mainfrom
Closed
fix: ignore empty SSL_CERT_FILE environment variable#184261cbyc wants to merge 1 commit intoastral-sh:mainfrom
1cbyc wants to merge 1 commit intoastral-sh:mainfrom
Conversation
Apply the same filtering logic used for other environment variables (e.g., NO_COLOR, FORCE_COLOR) to SSL_CERT_FILE. Empty values should be ignored rather than treated as valid paths. This aligns with the behavior of other environment variable handling in the codebase and prevents issues when SSL_CERT_FILE is set to an empty string. Fixes astral-sh#16712
Jah-yee
added a commit
to Jah-yee/uv
that referenced
this pull request
Mar 12, 2026
Apply the same filtering logic used for NO_COLOR and FORCE_COLOR to SSL_CERT_FILE. Empty values should be ignored rather than treated as valid paths. This aligns with the behavior of SSL_CERT_DIR which already uses this pattern. Fixes astral-sh#18426
Collaborator
|
Dupe of #16772 |
Collaborator
|
Fixed by #18550 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply the same filtering logic used for other environment variables
(e.g., NO_COLOR, FORCE_COLOR) to SSL_CERT_FILE. Empty values should
be ignored rather than treated as valid paths.
This aligns with the behavior of other environment variable handling
in the codebase and prevents issues when SSL_CERT_FILE is set to an
empty string.
Fixes #16712