Skip to content

chore: update versions in new project init#18417

Merged
konstin merged 2 commits intoastral-sh:mainfrom
henryiii:patch-2
Mar 13, 2026
Merged

chore: update versions in new project init#18417
konstin merged 2 commits intoastral-sh:mainfrom
henryiii:patch-2

Conversation

@henryiii
Copy link
Copy Markdown
Contributor

Summary

This updates the versions a bit in the new project init. Scikit-build-core updated to 0.12+, pybind11 updated to 3+ (which allows a small simplification), and PyO3 updated to 0.28.2+ (which is what I was running into, it was on an old version).

I also wanted to update the gitignore, as it's missing a bunch of things for Maturin (like target/* and *.so!), but I guess that's somewhere else.

Copy link
Copy Markdown
Member

@konstin konstin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing these updates!


[tool.uv]
cache-keys = [{ file = "pyproject.toml" }, { file = "src/**/*.{h,c,hpp,cpp}" }, { file = "CMakeLists.txt" }]
cache-keys = [{ file = "pyproject.toml" }, { file = "src/**/*.{h,c,hpp,cpp}" }, { file = "**/CMakeLists.txt" }]
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wary of adding a ** prefix here, it would mean we have to traverse the entire tree each time, which can be a performance hazard. src/** for example is less risky as users don't generally put large trees, say caches, data to be processed or venvs, into src.

Copy link
Copy Markdown
Contributor Author

@henryiii henryiii Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll remove it, I feel like I've wanted to add it before but we had the same conversation, yes, don't want to traverse into venvs and such. :)

(The problem is that users often have per-directory CMakeLists.txt) src would be pretty common, but you could also have some in include, for example. (and tests, but those don't natter for rebuilds).)

@konstin konstin added the enhancement New feature or improvement to existing functionality label Mar 12, 2026
Copy link
Copy Markdown
Member

@konstin konstin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@konstin konstin enabled auto-merge (squash) March 13, 2026 13:42
@konstin konstin merged commit 6541b47 into astral-sh:main Mar 13, 2026
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or improvement to existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants