Fix uv tool upgrade after Python version upgrade#18397
Open
charliermarsh wants to merge 1 commit intomainfrom
Open
Fix uv tool upgrade after Python version upgrade#18397charliermarsh wants to merge 1 commit intomainfrom
uv tool upgrade after Python version upgrade#18397charliermarsh wants to merge 1 commit intomainfrom
Conversation
charliermarsh
changed the title
uv tool upgrade after Python version upgrade
Member
|
Related to #18121 |
zanieb
reviewed
Mar 13, 2026
Comment on lines
+939
to
+941
| let content = fs_err::read_to_string(tool_dir.join("babel").join("pyvenv.cfg")).unwrap(); | ||
| let lines: Vec<&str> = content.split('\n').collect(); | ||
| assert_snapshot!(lines[lines.len() - 3], @"version_info = 3.12.[X]"); |
Member
There was a problem hiding this comment.
This seems pretty questionable? if we want to assert on that line we should extract it with a prefix match?
Member
|
I'm a little unsure it should repair the environment rather than skip it and encourage use of Why do you say "after Python version upgrade" in the title instead of "when Python interpreter is missing"? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
If a tool references a Python environment with a Python interpreter that no longer exists,
uv tool upgradenow reinstalls it. I think this is a reasonable improvement.Note that #17907 also claims that
uv tool install --forceis not working; it's hard to say why that's happening without an MRE.See: #17907.