Respect timestamp and other cache keys in cached environments#18396
Merged
charliermarsh merged 1 commit intomainfrom Mar 11, 2026
Merged
Respect timestamp and other cache keys in cached environments#18396charliermarsh merged 1 commit intomainfrom
charliermarsh merged 1 commit intomainfrom
Conversation
charliermarsh
force-pushed
the
charlie/cache-key-with
branch
from
5362779 to
59867b1
Compare
konstin
approved these changes
Mar 11, 2026
crates/uv/tests/it/run.rs
Outdated
Comment on lines
+1509
to
+1515
| .output()?; | ||
| assert!( | ||
| third.status.success(), | ||
| "third run failed:\nstdout:\n{}\nstderr:\n{}", | ||
| String::from_utf8_lossy(&third.stdout), | ||
| String::from_utf8_lossy(&third.stderr), | ||
| ); |
Member
There was a problem hiding this comment.
We get this pre-made from assert_cmd:
Suggested change
| .output()?; | |
| assert!( | |
| third.status.success(), | |
| "third run failed:\nstdout:\n{}\nstderr:\n{}", | |
| String::from_utf8_lossy(&third.stdout), | |
| String::from_utf8_lossy(&third.stderr), | |
| ); | |
| .assert() | |
| .success() | |
| .get_output(); |
crates/uv/tests/it/run.rs
Outdated
| ); | ||
|
|
||
| let third_stdout = String::from_utf8_lossy(&third.stdout).trim().to_string(); | ||
| assert_eq!( |
Member
There was a problem hiding this comment.
Is there a reason we're not using snapshots like in the other tests?
charliermarsh
force-pushed
the
charlie/cache-key-with
branch
from
59867b1 to
c2ec8ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We now take cache keys and timestamps into account when reusing environments via
--with, etc.Closes #16617.