Hide index URLs from header if not emitted #1835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
reviewed
Feb 21, 2024
zanieb
reviewed
Feb 21, 2024
|
Thanks for contributing again! I have a couple questions. |
DrJackilD
force-pushed
the
feat/hide-index-urls-if-not-emited
branch
4 times, most recently
from
8a4bdbe
to
8b116f6
Compare
| Some(Some(arg)) // keep this argument | ||
| } | ||
| }) | ||
| .flatten() | ||
| .join(" ") |
There was a problem hiding this comment.
This looks good to me, though I may pull it out to its own function.
There was a problem hiding this comment.
Sure, no problem, extracted to a separate function👍
Co-authored-by: Ivan Salamakha <[email protected]>
DrJackilD
force-pushed
the
feat/hide-index-urls-if-not-emited
branch
from
8b116f6
to
5276777
Compare
DrJackilD
force-pushed
the
feat/hide-index-urls-if-not-emited
branch
from
5276777
to
5f7d294
Compare
charliermarsh
approved these changes
Feb 23, 2024
charliermarsh
changed the title
charliermarsh
added
the
compatibility
charliermarsh
added a commit
that referenced
this pull request
Feb 23, 2024
charliermarsh
added a commit
that referenced
this pull request
Feb 23, 2024
|
Thank you! |
charliermarsh
added a commit
that referenced
this pull request
Feb 23, 2024
## Summary Like #1835, but for `--find-links` (for consistency).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Hey guys! The motivation described in #1834
Test Plan
Changed snapshot of the existing tests.
--index-urland--extra-index-urloccur pretty often, so no extra testing is required, imo.