Conversation
Signed-off-by: William Woodruff <william@astral.sh>
woodruffw
added
internal
woodruffw
changed the title
.json() instead of .body() to send mint-token requests
woodruffw
temporarily deployed
to
uv-test-publish
GitHub Actions
Inactive
woodruffw
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
EliteTK
approved these changes
Mar 5, 2026
Contributor
EliteTK
left a comment
EliteTK
left a comment
There was a problem hiding this comment.
Looks good.
Interesting error in CI though... Looks like we the reqwest dep doesn't have the json feature enabled in that scenario?
Member
Author
|
Oh yeah, I bet we need to add it to the per-crate features. I'll do that! |
Signed-off-by: William Woodruff <william@astral.sh>
woodruffw
temporarily deployed
to
uv-test-publish
GitHub Actions
Inactive
woodruffw
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Using
.body()meant that the request was sent without aContent-Type, whereas we want to explicitly communicate that the mint-token request is a JSON payload. Using.json()causes request to send theContent-Typeheader by default.Test Plan
Existing coverage.