platform-host: check /bin/sh, then /bin/dash and then /bin/ls #1818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we were only checking /bin/sh. While that works in most cases, it seems like there are still scenarios where /bin/sh isn't an executable itself, and is instead just a shell script that calls /bin/dash. (See #1810 for example.) In this PR, we make the `ld` detection a bit more robust by trying multiple paths. As with previous changes, we emit copious logs to help debug this in the future. It's not totally clear how to test this. I'm not sure how to reproduce the environment mentions in #1810 specifically since it seems like an internal variant of WSL Ubuntu. Fixes #1810
BurntSushi
force-pushed
the
ag/fix-i1810
branch
from
bbaedbb
to
5a50a3c
Compare
zanieb
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were only checking /bin/sh. While that works in most
cases, it seems like there are still scenarios where /bin/sh isn't an
executable itself, and is instead just a shell script that calls
/bin/dash. (See #1810 for example.)
In this PR, we make the
lddetection a bit more robust by tryingmultiple paths. As with previous changes, we emit copious logs to help
debug this in the future.
It's not totally clear how to test this. I'm not sure how to reproduce
the environment mentions in #1810 specifically since it seems like an
internal variant of WSL Ubuntu.
Fixes #1810