Fix supervisor race condition when spawning child processes on Windows#18171
Draft
zanieb wants to merge 1 commit intozb/fix-bounce-race-iifrom
Draft
Fix supervisor race condition when spawning child processes on Windows#18171zanieb wants to merge 1 commit intozb/fix-bounce-race-iifrom
zanieb wants to merge 1 commit intozb/fix-bounce-race-iifrom
Conversation
Set CREATE_SUSPENDED for Windows spawn supervision, assign the child to the job object, then resume the process. This removes the post-spawn assignment race for short-lived child processes. If job assignment fails, kill the suspended child before returning an error to avoid leaving a stuck suspended process.
zanieb
changed the title
zanieb
added
bug
zanieb
force-pushed
the
zb/fix-bounce-race-ii
branch
3 times, most recently
from
ad44925 to
b2ac908
Compare
samypr100
reviewed
Mar 2, 2026
Comment on lines
+82
to
+83
| // We use `NtResumeProcess` later because `std::process::Child` does not | ||
| // expose the primary thread handle needed for `ResumeThread`. |
Collaborator
There was a problem hiding this comment.
I think you can use #![feature(windows_process_extensions_main_thread_handle)] and then do child.main_thread_handle().as_raw_handle() instead which allows you to use ResumeThread and avoid NtResumeProcess.
edit: nevermind, this is still nighly only 😆 my head is stuck in trampoline which is nightly
Member
Author
|
We'll need an alternative of this like #18291 I presume |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the same as #18170 but for
uvxanduv runinstead of trampolines.