Normalize VIRTUAL_ENV path in activation scripts
#1817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
approved these changes
Feb 21, 2024
charliermarsh
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1763
This PR fixes the issue where the Path to the virtual environment used NT Paths thar are unsupported in CMD on Win 10 (I can't repro on win11) by normalizing the path.
Test Plan
I can't reproduce the mentioned issue locally because it works fine under Win 11 and I don't have access to Win 10.
But I verified that the path in the generated
activation.batisn't an NT Path.I verified that I can activate the virtual env in CMD and Powershell by running the activation scripts.